vector-knowledge-base-mcp-server

1. **Publicly Accessible Documents**: The MinIO bucket is configured for public read access. This makes all uploaded documents directly accessible via URL without authentication, posing a significant risk if sensitive information is stored. 2. **Default Credentials/Keys**: The `.env.example` and `config.py` provide default MinIO credentials ('minioadmin') and a placeholder 'ADMIN_API_KEY' ('changeme' in `api_util.py`). These *must* be changed for any production deployment. 3. **Filename Sanitization Vulnerability (CRITICAL)**: The `DocumentService.upload_documents` method directly uses `file.filename` from user uploads to construct file paths in MinIO without sufficient sanitization. Although a `make_clean_filename` function exists, it is commented out and not used. This allows for potential path traversal attacks (e.g., using `../../../` in filenames) or other file system manipulation if an attacker can craft a malicious filename. This could lead to unauthorized file creation, overwriting, or access outside the intended directories in MinIO, making it a critical vulnerability. 4. **Celery `asyncio.run` in worker**: Using `asyncio.run` inside a synchronous Celery task can lead to unexpected behavior and resource exhaustion if not handled carefully.